{ "tokens": { "input": 16789, "cache_read": 6835, "cache_write": 2734, "output": 2445 }, "reviews": [ { "key": [ "https://ftp.debian.org/debian/pool/main/c/ckermit/ckermit_416~beta12.orig.tar.gz", "main ckuusr.c:13423:2: error: Non-local variable 'xargv' will use pointer to local variable 'list'. [danglingLifetime]\n ckuusr.c:13418:11: note: Array decayed to pointer here.\n ckuusr.c:13407:9: note: Variable created here.\n ckuusr.c:13423:2: note: Non-local variable 'xargv' will use pointer to local variable 'list'." ], "verdict": { "verdict": "improvement", "confidence": "high", "explanation": "The danglingLifetime warning is still reported. Only the 'Array decayed to pointer here' note changed. Main pointed to line 13418 `list[i]`, which is a subscript, not a decay. The PR now points to line 13423 `xargv = list`, where the array really decays to a pointer. The warning itself is a true positive: the global xargv is left pointing to the local array list after the block ends. The message is now more accurate." } }, { "key": [ "https://ftp.debian.org/debian/pool/main/c/ckermit/ckermit_416~beta12.orig.tar.gz", "main ckuusr.c:13424:2: error: Non-local variable 'xargv' will use pointer to local variable 'list'. [danglingLifetime]\n ckuusr.c:13418:11: note: Array decayed to pointer here.\n ckuusr.c:13407:9: note: Variable created here.\n ckuusr.c:13424:2: note: Non-local variable 'xargv' will use pointer to local variable 'list'." ], "verdict": { "verdict": "improvement", "confidence": "high", "explanation": "The warning itself stays: `xargv = list;` stores the address of the local array `list` in the global `xargv`. That pointer outlives the block, so the danglingLifetime report is a real issue. Only the note changed. Main said the array decayed at `list[i]` (line 13418), which is just a subscript and not a decay. The PR now points at line 13423:10, the `xargv = list` assignment where the decay actually happens. The diagnostic is more accurate." } }, { "key": [ "https://ftp.debian.org/debian/pool/main/c/ckermit/ckermit_416~beta12.orig.tar.gz", "your ckuusr.c:13423:2: error: Non-local variable 'xargv' will use pointer to local variable 'list'. [danglingLifetime]\n ckuusr.c:13423:10: note: Array decayed to pointer here.\n ckuusr.c:13407:9: note: Variable created here.\n ckuusr.c:13423:2: note: Non-local variable 'xargv' will use pointer to local variable 'list'." ], "verdict": { "verdict": "improvement", "confidence": "high", "explanation": "The warning is a true positive. 'xargv = list;' stores the address of the local array 'list' in a global pointer, and the warning stays reported. Only the note changed. Main said the array decayed at line 13418 ('list[i]'), but that is a subscript, which accesses an element and does not use the array as a pointer. The note now points to 13423:10, the assignment 'xargv = list' where the decay actually happens. The message is more accurate." } }, { "key": [ "https://ftp.debian.org/debian/pool/main/c/ckermit/ckermit_416~beta12.orig.tar.gz", "your ckuusr.c:13424:2: error: Non-local variable 'xargv' will use pointer to local variable 'list'. [danglingLifetime]\n ckuusr.c:13423:10: note: Array decayed to pointer here.\n ckuusr.c:13407:9: note: Variable created here.\n ckuusr.c:13424:2: note: Non-local variable 'xargv' will use pointer to local variable 'list'." ], "verdict": { "verdict": "improvement", "confidence": "high", "explanation": "The code does `xargv = list;` at line 13423, where `list` is a local array, and `xargv` is a global. The decay really happens there, so the danglingLifetime warning itself is a true positive. The PR only changes the 'Array decayed to pointer here' note. Main pointed to `list[i]` at line 13418, which is a subscript and not a decay. The new output points to the real decay at `xargv = list` (13423:10). The message is now more accurate." } }, { "key": [ "https://ftp.debian.org/debian/pool/main/f/funtools/funtools_1.4.8.orig.tar.gz", "your funtools-1.4.8/gnu/sort.c:1620:23: warning: Either the condition 'i