{ "tokens": { "input": 3183, "cache_read": 5193, "cache_write": 5193, "output": 2487 }, "reviews": [ { "key": [ "https://ftp.debian.org/debian/pool/main/a/alsaplayer/alsaplayer_0.99.82.orig.tar.gz", "your alsaplayer-0.99.82/input/vorbis/vorbis_engine.c:226:3: warning:inconclusive: Array 'pcmout' is filled incompletely. Did you forget to multiply the size given to 'memcpy()' with 'sizeof(*pcmout)'? [incompleteArrayFill]" ], "verdict": { "verdict": "regression", "confidence": "medium", "explanation": "pcmout is a short array of BLOCK_SIZE_BYTES/sizeof(buf[0]) elements. The PR now resolves this sizeof-based dimension, so the size is known and the incompleteArrayFill check fires. However, `memcpy(pcmout, buf, sizeof(pcmout) / 2)` deliberately copies only half the buffer. That half holds the mono samples, which the loop below then expands to stereo using count = sizeof(pcmout)/(2*sizeof(short)). The byte count only happens to equal the element count because sizeof(short)==2; nobody forgot a sizeof multiplication. The new warning is a false positive." } }, { "key": [ "https://ftp.debian.org/debian/pool/main/m/milkytracker/milkytracker_1.06+dfsg.orig.tar.xz", "your MilkyTracker-1.06/src/tracker/ScopesControl.cpp:99:2: portability:inconclusive: Array 'onOffState' might be filled incompletely. Did you forget to multiply the size given to 'memset()' with 'sizeof(*onOffState)'? [incompleteArrayFill]" ], "verdict": { "verdict": "regression", "confidence": "high", "explanation": "The call is `memset(onOffState, 0, sizeof(onOffState))`. `sizeof` of a real array member gives its full size in bytes, so the whole array is always cleared, whatever size `bool` has on a platform. The portability/inconclusive wording implies `onOffState` is a `bool` array. The check warns because the computed `sizeof` value equals the element count, which is true when `sizeof(bool)==1`. The PR newly resolves the array dimension (`TrackerConfig::MAXCHANNELS`) and so the value of `sizeof(onOffState)`. That exposes the check's comparison and produces a new false positive." } } ], "started": "2026-11-18 03:02:51 UTC", "runner": "aws-testrunner-3" }