AI review of 2026-11-17_10-27-25-54fd8e469bcd-results.txt PR: #9034 https://github.com/cppcheck-opensource/cppcheck/pull/9034 Tested: 54fd8e469bcd526c35eca9d8845075a3f54f0466 Merge base: e6188446626b9e3c0cd16ffe0e49c73b18e52793 Reviewed: 2026-11-17 16:25:48 UTC Model: claude-opus-5-5 (effort high) Results: 2 reviewed of 2 in the report Verdicts: 2 improvement Tokens: 5282 input, 12432 cache read, 12432 cache write, 1158 output The verdicts are written by AI and can be wrong. ---- 1 / 2 ---- Verdict: IMPROVEMENT (medium confidence) Package: https://ftp.debian.org/debian/pool/main/o/oce/oce_0.18.3.orig.tar.gz Result: main oce-OCE-0.18.3/src/IGESFile/structiges.c:105:57: warning: Either the condition 'lentext>=10000' is redundant or the array 'newtext[1]' is accessed at index 9999, which is out of bounds. [arrayIndexOutOfBoundsCond] oce-OCE-0.18.3/src/IGESFile/structiges.c:96:17: note: Assuming that condition 'lentext>=10000' is not redundant oce-OCE-0.18.3/src/IGESFile/structiges.c:93:32: note: Assuming condition is true oce-OCE-0.18.3/src/IGESFile/structiges.c:105:19: note: Assignment 'i=lentext-1', assigned value is 9999 oce-OCE-0.18.3/src/IGESFile/structiges.c:105:57: note: Array index out of bounds Explanation: The warning itself is unchanged and is reported by both versions. The PR only adds an error-path note: 'Calling function iges_newchar, 1st argument "" value is ""' (line 226). This note shows where the size of 'newtext[1]' comes from, which main left unexplained. The warning itself is doubtful: it likely combines the empty-string argument from one call site with the 'lentext>=10000' condition. Even so, the extra note lets users see this and judge the warning. The diagnostic became more informative, not less accurate, so this is an improvement. ---- 2 / 2 ---- Verdict: IMPROVEMENT (medium confidence) Package: https://ftp.debian.org/debian/pool/main/o/oce/oce_0.18.3.orig.tar.gz Result: your oce-OCE-0.18.3/src/IGESFile/structiges.c:105:57: warning: Either the condition 'lentext>=10000' is redundant or the array 'newtext[1]' is accessed at index 9999, which is out of bounds. [arrayIndexOutOfBoundsCond] oce-OCE-0.18.3/src/IGESFile/structiges.c:226:25: note: Calling function 'iges_newchar', 1st argument '""' value is "" oce-OCE-0.18.3/src/IGESFile/structiges.c:96:17: note: Assuming that condition 'lentext>=10000' is not redundant oce-OCE-0.18.3/src/IGESFile/structiges.c:93:32: note: Assuming condition is true oce-OCE-0.18.3/src/IGESFile/structiges.c:105:19: note: Assignment 'i=lentext-1', assigned value is 9999 oce-OCE-0.18.3/src/IGESFile/structiges.c:105:57: note: Array index out of bounds Explanation: The same arrayIndexOutOfBoundsCond warning is reported by both versions. The only difference is a new note saying the 'newtext[1]' size comes from the call at line 226, where iges_newchar is passed "". This is exactly what the PR intends: it adds the error path of the string-literal value. Before, users could not tell why 'newtext' was treated as a 1-byte array. The warning itself is likely a false positive: the "" call almost certainly passes lentext=0, which cannot meet 'lentext>=10000'. Still, the PR neither adds nor removes it. It only makes the message more traceable, so the change is a slight improvement in message accuracy.