AI review of 2026-11-17_12-19-27-84aa8d9cb789-results.txt PR: #8981 https://github.com/cppcheck-opensource/cppcheck/pull/8981 Tested: 84aa8d9cb78918fca52e314a4514cd58362235db Merge base: 530e59ff2e4a79db9da937ac6d8d60342c84d898 Reviewed: 2026-11-18 06:29:36 UTC Model: claude-opus-5-5 (effort high) Results: 1 reviewed of 1 in the report, the test is still running (900 analysed of 1000 requested packages) Verdicts: 1 improvement Tokens: 1671 input, 0 cache read, 1702 cache write, 735 output The verdicts are written by AI and can be wrong. ---- 1 / 1 ---- Verdict: IMPROVEMENT (high confidence) Package: https://ftp.debian.org/debian/pool/main/p/pmdk/pmdk_1.13.1.orig.tar.gz Result: your pmdk-1.13.1/src/common/rand.c:57:16: style:inconclusive: Function 'rnd64_r' argument 1 names different: declaration 'rng' definition 'state'. [funcArgNamesDifferent] pmdk-1.13.1/src/common/rand.h:20:25: note: Function 'rnd64_r' argument 1 names different: declaration 'rng' definition 'state'. pmdk-1.13.1/src/common/rand.c:57:16: note: Function 'rnd64_r' argument 1 names different: declaration 'rng' definition 'state'. Explanation: In pmdk, `rng_t` is an array typedef (`uint64_t[4]`). After typedef simplification, the header prototype `uint64_t rnd64_r(rng_t *rng);` becomes `uint64_t rnd64_r(uint64_t (*rng)[4]);`. Before this PR, Cppcheck read that prototype as a variable declared with an initializer, so the parameter `rng` got no variable id and the name check was skipped. The PR now treats `( * name ) [` as a parameter declaration. The declaration uses `rng` and the definition in rand.c uses `state`, so the new funcArgNamesDifferent warning is a true positive.