{
 "tokens": {
  "input": 3321,
  "cache_read": 3075,
  "cache_write": 3075,
  "output": 289
 },
 "reviews": [
  {
   "key": [
    "https://ftp.debian.org/debian/pool/main/j/john/john_1.9.0.orig.tar.xz",
    "your john-1.9.0/src/loader.c:903:6: style: Condition '!hash' is always false [knownConditionTrueFalse]\n     john-1.9.0/src/loader.c:902:14: note: Assignment 'hash=p[0]|0x20', assigned value is never 0\n     john-1.9.0/src/loader.c:903:6: note: Condition '!hash' is always false"
   ],
   "verdict": {
    "verdict": "improvement",
    "confidence": "high",
    "explanation": "On line 902, `hash = p[0] | 0x20` always has bit 0x20 set, so `hash` can never be 0. The check `!hash` on line 903 is therefore always false, and the `goto out` is dead code. The author probably meant to detect an empty string (p[0]==0), but OR-ing with 0x20 makes that impossible. This is a genuine logic bug, so the new warning is a true positive."
   }
  },
  {
   "key": [
    "https://ftp.debian.org/debian/pool/main/j/john/john_1.9.0.orig.tar.xz",
    "your john-1.9.0/src/loader.c:906:6: style: Condition '!extra' is always false [knownConditionTrueFalse]\n     john-1.9.0/src/loader.c:905:15: note: Assignment 'extra=p[1]|0x20', assigned value is never 0\n     john-1.9.0/src/loader.c:906:6: note: Condition '!extra' is always false"
   ],
   "verdict": {
    "verdict": "improvement",
    "confidence": "high",
    "explanation": "`extra = p[1] | 0x20` always has bit 0x20 set, so it can never be 0 and `!extra` is always false. This is a true positive. It looks like an upstream bug: the author probably meant to test p[1] for the end of the string (NUL) before OR-ing. The new check reports it correctly."
   }
  }
 ],
 "started": "2026-11-01 01:06:20 UTC",
 "runner": "pc"
}