{
 "tokens": {
  "input": 3304,
  "cache_read": 2929,
  "cache_write": 2929,
  "output": 412
 },
 "reviews": [
  {
   "key": [
    "https://ftp.debian.org/debian/pool/main/t/telegram-desktop/telegram-desktop_5.7.2+ds.orig.tar.xz",
    "your tdesktop-5.7.2-full/Telegram/SourceFiles/boxes/add_contact_box.cpp:116:6: style: Condition '!success' is always false [knownConditionTrueFalse]"
   ],
   "verdict": {
    "verdict": "regression",
    "confidence": "high",
    "explanation": "`success` is built by chaining lambdas with an overloaded `operator|` (base::optional pipe). It is an optional/bool result that can be empty or false at runtime, for example when the updates type is unexpected or the chats list is empty. The PR's new valueflow rule treats every binary `|` with a non-zero lambda operand as an integer bitwise OR and marks the result as impossible 0. It does not check that the operator is overloaded or that the operands are class/lambda types. That is why `!success` is now reported as always false. This is a false positive."
   }
  },
  {
   "key": [
    "https://ftp.debian.org/debian/pool/main/t/telegram-desktop/telegram-desktop_5.7.2+ds.orig.tar.xz",
    "your tdesktop-5.7.2-full/Telegram/SourceFiles/boxes/add_contact_box.cpp:872:7: style: Condition '!success' is always false [knownConditionTrueFalse]"
   ],
   "verdict": {
    "verdict": "regression",
    "confidence": "high",
    "explanation": "Here `|` is an overloaded operator from base/optional that chains lambdas over std::optional (a monadic bind). It is not an integer bitwise OR. `success` is an optional that can be empty, for example when the update type is unexpected or the chat is not a channel, so `!success` can be true. The new valueflow rule marks any binary `|` as impossible-0 when one operand looks non-null. It does not check that the operands are integral or that the operator is the builtin one. Here the non-null operand is `make_optional(&result)` or a lambda. The resulting warning is a false positive."
   }
  }
 ],
 "started": "2026-10-30 05:26:29 UTC",
 "runner": "aws-testrunner-1"
}