AI review of 2026-11-10_17-59-48-3529ec440e02-results.txt PR: #8963 https://github.com/cppcheck-opensource/cppcheck/pull/8963 Tested: 3529ec440e0229a663ff26f0a36513aa425fcf14 Merge base: 3f70597aead4f246f92613ef8a07cbb636c14f29 Reviewed: 2026-11-20 10:07:52 UTC Model: claude-opus-5-5 (effort high) Results: 1 reviewed of 1 in the report Verdicts: 1 improvement Tokens: 1998 input, 0 cache read, 4103 cache write, 1049 output The verdicts are written by AI and can be wrong. ---- 1 / 1 ---- Verdict: IMPROVEMENT (medium confidence) Package: https://ftp.debian.org/debian/pool/main/x/xen/xen_4.20.4+63-g7abfd2bce2.orig.tar.xz Result: main xen-4.20.4+63-g7abfd2bce2/tools/debugger/kdd/kdd.c:816:19: error: Array 's->txb[56]' accessed at index 271, which is out of bounds. [arrayIndexOutOfBounds] xen-4.20.4+63-g7abfd2bce2/tools/debugger/kdd/kdd.c:815:23: note: Assuming that condition 'i<0x100' is not redundant xen-4.20.4+63-g7abfd2bce2/tools/debugger/kdd/kdd.c:816:19: note: Array index out of bounds Explanation: In kdd.c, `txb` sits in an anonymous union with `kdd_pkt txp` and is sized from the packet types. Main computed its size as only 56 because it counted just one member of the nested anonymous union in `kdd_pkt`. The surrounding code shows the buffer is much larger: `kdd_send_string` writes up to 0xffff bytes into `txb` after the header. So the reported out-of-bounds write at index 271 (header + 255) was a false positive. The PR fixes sizeof for structs containing anonymous unions, and the warning disappears.