{ "tokens": { "input": 1250, "cache_read": 0, "cache_write": 2170, "output": 524 }, "reviews": [ { "key": [ "https://ftp.debian.org/debian/pool/main/s/spout/spout_1.4.orig.tar.bz2", "your spout-1.4/spout.c:974:27: style: Comparing expression of type 'char' against value 128. Condition is always true. [compareValueOutOfTypeRangeError]" ], "verdict": { "verdict": "improvement", "confidence": "medium", "explanation": "`*pC` is a plain `char`. The PR makes Cppcheck treat plain char as signed when the platform's default sign is signed, as on x86 Unix. On such a platform the range of `*pC` is -128..127, so `*pC < 0x80` is indeed always true, and the new warning is correct for the configured platform. This is exactly the case the PR targets (#11592). The test is not useless on unsigned-char platforms such as ARM, which makes the warning somewhat debatable for portable code. Still, it correctly reports a redundant comparison under the analyzed platform settings. It also hints at a real portability issue: on signed-char platforms, bytes >= 0x80 pass the first check only if they are >= 0x20, which they never are, so they fall to the else branch anyway." } } ], "started": "2026-10-14 18:51:59 UTC", "runner": "server" }