AI review of 2025-12-09_19-19-12-dd79f1602d01-results.txt
PR:          #8016 https://github.com/cppcheck-opensource/cppcheck/pull/8016
Tested:      dd79f1602d01c3ccd3984656643cd27c5bd6e8c8
Merge base:  5b70f39c38e6bd073d4319b40ace89e76416d25e
Reviewed:    2026-10-07 20:18:57 UTC
Model:       claude-opus-5-5 (effort high)
Results:     1 reviewed of 1 in the report
Verdicts:    1 regression
Tokens:      2361 input, 0 cache read, 1674 cache write, 520 output

The verdicts are written by AI and can be wrong.

---- 1 / 1 ----
Verdict:     REGRESSION (medium confidence)
Package:     https://ftp.debian.org/debian/pool/main/s/subversion/subversion_1.14.5.orig.tar.gz
Result:      your subversion-1.14.5/subversion/libsvn_client/diff.c:423:16: style: Condition 'old_mode==new_mode' is always true [knownConditionTrueFalse]
     subversion-1.14.5/subversion/libsvn_client/diff.c:421:16: note: new_mode is assigned '(exec_bit2?exec_mode:noexec_mode)|(symlink_bit2?kind_symlink_mode:kind_file_mode)' here.
     subversion-1.14.5/subversion/libsvn_client/diff.c:419:16: note: old_mode is assigned '(exec_bit1?exec_mode:noexec_mode)|(symlink_bit1?kind_symlink_mode:kind_file_mode)' here.
     subversion-1.14.5/subversion/libsvn_client/diff.c:423:16: note: Condition 'old_mode==new_mode' is always true
Explanation: old_mode and new_mode are built from separate parameters (exec_bit1/exec_bit2, symlink_bit1/symlink_bit2). Callers pass these from the left and right properties, so the two modes can differ. That is the whole point of the 'old mode/new mode' output below the check. Claiming 'old_mode==new_mode' is always true is a false positive. The PR only touches CMake build options, so the new warning likely comes from nondeterministic or build-related analysis differences. Either way, the added report is wrong.